Re: [Xen-devel] [PATCH 6/8] libxl: allow a generation ID to be specified at domain creation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 16:04 +0100, David Vrabel wrote:
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index f0f6e34..1c5e687 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -371,6 +371,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                         ("xen_platform_pci", libxl_defbool),
>                                         ("usbdevice_list",   
> libxl_string_list),
>                                         ("vendor_device",    
> libxl_vendor_device),
> +                                       # See libxl_ms_vm_genid_generate()
> +                                       ("ms_vm_genid",      libxl_uuid),

When we discussed this IRL I thought we had decided that this should be
a new libxl_ms_vm_genid type, effectively a typedef of uint8_t[16],
similar to libxl_mac and libxl_hwcap[[0]]. This would avoid any
suggestion that one of the more structured forms of UUID would be
appropriate here.

I appreciate that you tried to address that with the comment, but I fear
it might not be terribly effective in practice...

Other than that the implementation here all looks ok to me.

Ian.

[[0]] I suppose we are getting to close to wanting idl.py to contains
Bytes(n) as a generic type. I won't ask you to do that though.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel