Re: [Xen-devel] [PATCH 1/8] libxc: allow xc_get/set_hvm_param() to get/set 64-bit values

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 16:04 +0100, David Vrabel wrote:
> HVMOP_get_param and HVMOP_set_param take a uint32_t for the parameter
> index and a uint64_t for the value.  So, make the corresponding libxc
> function take the same types.

Sadly:

<builddir>tools/qemu-xen-dir/xen-all.c: In function 'xen_hvm_init':
<builddir>tools/qemu-xen-dir/xen-all.c:1101:5: error: passing argument 4 of 
'xc_get_hvm_param' from incompatible pointer type [-Werror]
In file included from 
<builddir>tools/qemu-xen-dir/include/hw/xen/xen_common.h:9:0,
                 from <builddir>tools/qemu-xen-dir/xen-all.c:15:
<builddir>tools/../tools/libxc/xenctrl.h:1812:5: note: expected 'uint64_t *' 
but argument is of type 'long unsigned int *'
<builddir>tools/qemu-xen-dir/xen-all.c:1110:5: error: passing argument 4 of 
'xc_get_hvm_param' from incompatible pointer type [-Werror]
In file included from 
<builddir>tools/qemu-xen-dir/include/hw/xen/xen_common.h:9:0,
                 from <builddir>tools/qemu-xen-dir/xen-all.c:15:
<builddir>tools/../tools/libxc/xenctrl.h:1812:5: note: expected 'uint64_t *' 
but argument is of type 'long unsigned int *'
<builddir>tools/qemu-xen-dir/xen-all.c:1132:13: error: passing argument 4 of 
'xc_get_hvm_param' from incompatible pointer type [-Werror]
In file included from 
<builddir>tools/qemu-xen-dir/include/hw/xen/xen_common.h:9:0,
                 from <builddir>tools/qemu-xen-dir/xen-all.c:15:
<builddir>tools/../tools/libxc/xenctrl.h:1812:5: note: expected 'uint64_t *' 
but argument is of type 'long unsigned int *'
cc1: all warnings being treated as errors

So I don't think it is going to be possible to just make this change so
easily. You'd need to to at least upstream a qemu patch which involved a
configure check I think :-(

You might find it easier to introduce a new name for these functions,
although sadly the only really sensible one is already taken...

:-/

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel