Re: [Xen-devel] [PATCH v2 4/6] libxl: spawn a qemu to implement channels

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-16 at 10:49 +0100, David Scott wrote:
> Since every channel is mapped to a console device in xenstore
> with 'output=chardev:libxl-channel%d', we need to tell qemu
> to create the appropriate chardevs.
> 
> Signed-off-by: David Scott <dave.scott@xxxxxxxxxx>

Looks good but could have been squashed with all the other libxl
patches.

> ---
>  tools/libxl/libxl_create.c   |    3 ++-
>  tools/libxl/libxl_dm.c       |   39 +++++++++++++++++++++++++++++++++++++--
>  tools/libxl/libxl_internal.h |    3 ++-
>  3 files changed, 41 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 6356e55..e178672 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -1214,7 +1214,8 @@ static void domcreate_launch_dm(libxl__egc *egc, 
> libxl__multidev *multidev,
>  
>          need_qemu = libxl__need_xenpv_qemu(gc, 1, &console,
>                  d_config->num_vfbs, d_config->vfbs,
> -                d_config->num_disks, &d_config->disks[0]);
> +                d_config->num_disks, &d_config->disks[0],
> +                d_config->num_channels);

It's really time that we started passing d_config to this function...
(not your problem here, carry on...)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel