[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] mini-os: fix bit ops comments and memory clobbers.

On Wed, 2014-06-18 at 15:58 +0100, Ian Campbell wrote:
> On Wed, 2014-06-18 at 10:29 +0200, Samuel Thibault wrote:
> > This fixes comments about test_and_clear_bit, set_bit and clear_bit,
> > which are actually not atomic, can be reordered and are not memory
> > barriers.
> > 
> > This also drops the empty LOCK and LOCK_PREFIX macros which bring to the
> > confusion.
> It took me a little while to work out that the reason these aren't
> needed is that you have synch_set_bit for the cases where the lock is
> actually needed.
> > This also adds missing memory clobbers to set_bit and clear_bit.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


<build>/stubdom/../extras/mini-os/include/x86/mini-os/arch_spinlock.h: In 
function â_raw_spin_lockâ:
error: expected â:â or â)â before âLOCKâ
<build>/stubdom/../extras/mini-os/include/x86/mini-os/arch_spinlock.h: In 
function â_raw_spin_lock_flagsâ:
error: expected â:â or â)â before âLOCKâ


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.