Re: [Xen-devel] [PATCH] mini-os: fix bit ops comments and memory clobbers.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-18 at 15:58 +0100, Ian Campbell wrote:
> On Wed, 2014-06-18 at 10:29 +0200, Samuel Thibault wrote:
> > This fixes comments about test_and_clear_bit, set_bit and clear_bit,
> > which are actually not atomic, can be reordered and are not memory
> > barriers.
> > 
> > This also drops the empty LOCK and LOCK_PREFIX macros which bring to the
> > confusion.
> 
> It took me a little while to work out that the reason these aren't
> needed is that you have synch_set_bit for the cases where the lock is
> actually needed.
> 
> > This also adds missing memory clobbers to set_bit and clear_bit.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

But:

<build>/stubdom/../extras/mini-os/include/x86/mini-os/arch_spinlock.h: In 
function â_raw_spin_lockâ:
<build>/stubdom/../extras/mini-os/include/x86/mini-os/arch_spinlock.h:83:10: 
error: expected â:â or â)â before âLOCKâ
<build>/stubdom/../extras/mini-os/include/x86/mini-os/arch_spinlock.h: In 
function â_raw_spin_lock_flagsâ:
<build>/stubdom/../extras/mini-os/include/x86/mini-os/arch_spinlock.h:90:10: 
error: expected â:â or â)â before âLOCKâ

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel