Re: [Xen-devel] [PATCH v5 06/21] xen/arm: segregate and split GIC low level functionality

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 06/19/2014 10:56 AM, Vijay Kilari wrote:
> On Fri, Jun 13, 2014 at 4:14 AM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>> Hi Vijay,
>>
>> In my answer I prefixed every comments I made on V4 but you didn't
>> address/answer by "From V4".
>>>   static void gic_restore_pending_irqs(struct vcpu *v)
>>>   {
>>> -    int lr = 0, lrs = nr_lrs;
>>> +    int lr = 0, lrs;
>>>       struct pending_irq *p, *t, *p_r;
>>>       struct list_head *inflight_r;
>>>       unsigned long flags;
>>> +    unsigned int nr_lrs = gic_hw_ops->info->nr_lrs;
>>>
>>> +    lrs = nr_lrs;
>>
>>
>> From V4:
>>
>> Hmmm ... why did you create a temporary variable nr_lrs to set lrs just
>> after???
> 
> This function uses both global variable nr_lrs and local variable lrs.
> With this patch, nr_lrs is replaced with gic_hw_ops->info->nr_lrs.
> So variable nr_lrs is now made local.
> 

Can you just do

unsigned int nr_lrs = gic_hw_ops->info->nr_lrs;
int lrs = nr_lrs;

I found this way less confusing.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel