Re: [Xen-devel] [PATCH RFC] xen/arm : emulation of arm's psci v0.2 standard

[Parth Dixit <parth.dixit@xxxxxxxxxx>]

Next version of my patch is ready except for following things on which i need your suggestion

1. Exposing PSCI v0.2 functions in device tree - This was not done because it gives the impression that you can modify the function id's and kernel will call the function id's based on function id's exposed in device tree whereas kernel ignores it for PSCI v0.2 while it follows it for PSCI v0.1 which can be confusing. Either way is fine with me.

2. ÂWhy do you clear the IRQ flag in psci_suspend - I am taking cue from the "vcpu_block_enable_events" in xen/common/schedule.c where flag is cleared to enable interrupts before pausing the cpu.

I have taken care of rest of the comments.

Regards

parth

On 20 June 2014 17:32, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

On 20/06/14 12:48, Stefano Stabellini wrote:

And yes, the idea is to have a single device tree node, and then psci
v0.1 only kernels can still use psci v0.1, and psci v0.2 can ignore
the function IDs and use the ones defined as per the spec.

OK. From the Xen POV we need to expose a psci node compatible with both
psci-0.2 and psci, because we want 3.15 to be able to boot with multiple
vcpus on Xen 4.5.

AFAIU parth's patch, this is already possible. He doesn't add the properties such as suspend because we don't support them on Xen for PSCI v0.1

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel