Re: [Xen-devel] [PATCH net v2] xen-netback: bookkeep number of active queues in our own module

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jun 22, 2014 at 05:21:05PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
> Date: Sun, 22 Jun 2014 14:31:41 +0100
> 
> >  
> > +   /* Initialisation completed, tell core driver the number of
> > +    * active queues.
> > +    */
> > +   rtnl_lock();
> > +   netif_set_real_num_tx_queues(be->vif->dev, requested_num_queues);
> > +   netif_set_real_num_rx_queues(be->vif->dev, requested_num_queues);
> > +   rtnl_unlock();
> > +
> >     xenvif_carrier_on(be->vif);
> 
> This function _NEVER_ set the number of RX queues beforehand,
> therefore why are you adding an RX queue adjustment now?
> 

As I went through the core driver code I found this to be a missing call
in previous code.

"In current Xen multiqueue design, the number of TX queues and RX queues
are in fact the same. So we need to set the numbers of TX and RX queues
to the same value."

Does the above paragraph answers your question? If so, I will add it to
commit message and resend this patch.

> Regardless of the reason, you must explain such a change, in
> detail, in your commit message.
> 
> Your previous patch didn't do this, and I really am suspect as to
> whether you functionally tested and verified this aspect of your
> change at a ll.
> 

I've done some testing.

> Please don't "quietly" make undescribed changes like this. It's very
> tiring to think that a patch has been adjusted to my liking and then
> during review I find a grenade like this :-/
> 

Sorry, that wasn't my intent.

Wei.

> Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel