Re: [Xen-devel] [PATCH v3 3/3] xl: add support for channels

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

David Scott writes ("[PATCH v3 3/3] xl: add support for channels"):
> This adds support for channel declarations of the form:
>   channel = [ "name=...,kind=...[,path=...][,backend=...]" ]

> +    if (!xlu_cfg_get_list (config, "channel", &channels, 0, 0)) {
> +        d_config->num_channels = 0;
> +        d_config->channels = NULL;
> +        while ((buf = xlu_cfg_get_listitem (channels,
> +                d_config->num_channels)) != NULL) {
> +            libxl_device_channel *chn;
> +            char *buf2 = strdup(buf);
> +            char *p, *p2;
> +            chn = ARRAY_EXTEND_INIT(d_config->channels, 
> d_config->num_channels,
> +                                    libxl_device_channel_init);

I appreciate that you're just following the example of the vif
configuration here, but I think this is rather too much open-coded
string handling.

> +                if (!strcmp(p, "backend")) {
> +                    free(chn->backend_domname);
> +                    chn->backend_domname = strdup(p2 + 1);

At the very least, can we provide a macro or function or something to
do this ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel