[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Rewind toolstack_save_fd in libxl_save_helper when using remus

Jason Andryuk writes ("Re: [PATCH] libxl: Rewind toolstack_save_fd in 
libxl_save_helper when using remus"):
> On 6/20/2014 2:59 AM, Yang Hongyang wrote:
> > commit(b327a3f421bb57d262b7d1fb3c43b710852b103b) move the rewinding
> > of toolstack_save_fd to libxl, this breaks remus, because in remus
> > mode, toolstack_save_cb will be called in every checkpoint, if
> > we don't rewind it in libxl_save_helper, it will surely encounted
> > error.
> > 
> > I know this fix is just a hack, in fact the whole toolstack save
> > thing should be done in libxl. But this fix should solve Jason's
> > case and remus thing. Until migration v2 is upstreamed, this fix
> > should be fine.
> > 
> > Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> > CC: Jason Andryuk <andryuk@xxxxxxxx>
> > CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Whoops, I didn't realize I broke Remus.  
> A quick test has migration still working for me.

Thanks to Yang Hongyang for the patch, to Andrew for the review, and
Jason for the test.  I have applied it.  I reworded the commit


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.