Re: [Xen-devel] [PATCH] tools/libxl: Fix free() of wild pointer in libxl__initiate_device_remove()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("[PATCH] tools/libxl: Fix free() of wild pointer in 
libxl__initiate_device_remove()"):
> libxl__initiate_device_remove() had a preexisting error path issue where
> libxl_dominfo_dispose() could be called on a libxl_dominfo object before it
> had been initialised with libxl_dominfo_init().
> 
> This was safe until c/s ab44401 added the pointer ssid_label, which point
> libxl_dominfo_dispose() free()s.
> 
> Unconditionally initialise info in libxl__initiate_device_remove() before
> taking an error path which will free it.
> 
> Coverity-ID: 1223212
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel