Re: [Xen-devel] [PATCH] add missing cpufeatures, vmexits and vmcs defines for broadwell/haswell

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jason L. Wright [mailto:jason@xxxxxxxxxxx]
> Sent: Wednesday, June 18, 2014 9:11 AM
> 
> On Jun 18, 2014, at 10:05 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
> >>>> On 18.06.14 at 17:53, <jason@xxxxxxxxxxx> wrote:
> >> Signed-off-bye: Jason L. Wright <jason@xxxxxxxxxxx>
> >> ---
> >> xen/include/asm-x86/cpufeature.h   | 6 ++++++
> >> xen/include/asm-x86/hvm/vmx/vmcs.h | 5 +++++
> >> xen/include/asm-x86/hvm/vmx/vmx.h  | 5 +++++
> >> 3 files changed, 16 insertions(+)
> >
> > Kind of a benign (not to say pointless) change without the new
> > definitions actually being used?
> >
> Saves one the time of having to find the definitions scattered
> among the manuals... Like I was doing hacking on something
> else.
> 
> -Jason L. Wright

better to have real usage together with the definition change, otherwise
it causes more confusion on how Xen actually uses them...

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel