Re: [Xen-devel] [PATCH ARM v4 12/12] mini-os: added ARM grant table initialisation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-25 at 17:41 +0100, Thomas Leonard wrote:
> On 18 June 2014 18:27, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> > Hi Thomas,
> >
> > On 06/18/2014 04:08 PM, Thomas Leonard wrote:
> >> +
> >> +/* Get Xen's sugggested physical page assignments for the grant table. */

Too many g's.

> >> +static grant_entry_t *get_gnttab_base(void)
> >> +{
> >> +    int hypervisor;
> >> +
> >> +    hypervisor = fdt_path_offset(device_tree, "/hypervisor");
> >
> > Same comment as on patch #11, you need to search the hypervisor node via
> > the compatible string.
> 
> It's not clear to me what I should do with this attribute. On
> Xen/unstable, it contains the single value "xen,xen-4.5",

It should contain "xen,xen-X.Y\0xen,xen\0\0", i.e. multiple strings. If
you don't care about the specific version then you should check for
"xen,xen" somewhere in the list.

(This is how device tree compatibile strings work, more specific to more
general).

>  meaning (I
> think) that Xen 4.5 is incompatible with Xen 4.4. But I'd still like
> Mini-OS to run. Presumably, 4.6 will be incompatible too. What could I
> do if the value doesn't match except try to use it anyway?
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel