Re: [Xen-devel] [arm] machine reset for sunxi

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-25 at 16:47 +0100, Ian Campbell wrote:
> On Wed, 2014-06-25 at 17:29 +0200, v1ne wrote:
> > I'm sorry, but I forgot the header containing the register offsets and
> > constants in the first patch.
> 
> Thanks. To be accepted into the Xen source tree this needs a
> Signed-off-by and a commit log as described in
> http://wiki.xen.org/wiki/Submitting_Xen_Patches
> 
> However, since we use PSCI for SMP support on this platform I think what
> we would really like is for u-boot to support the PSCI reset function as
> well, in which case Xen will just use it.

Scratch that, PSCI 0.1 which is all we currently support, doesn't
include reset functionality.

So if you resend the patch as described and with the review comments
below addressed then we should be able to take it.

Once PSCI 0.2 host support is implemented we can prefer it to the
platform specific mechanisms when present.

> +    writel(SUNXI_WDT_MODE_EN | SUNXI_WDT_MODE_RST_EN, wdt + ((SUNXI_WDT_BASE 
> + SUNXI_WDT_MODE) & ~PAGE_MASK));

Can you wrap this long line a bit please. Perhaps by setting up base and
offset variables and using those? Or:

     paddr_t addr = SUNXI_WDT_BASE + SUNXI_WDT_MODE;

then addr & PAGE_MASK and addr & ~PAGE_MASK etc.

+    iounmap(wdt);
> +
> +    for (;;)
> +    {

You don't need these braces.

> +      __asm("wfi");

We have a wfi() helper for this.

diff --git a/xen/include/asm-arm/platforms/sunxi.h 
b/xen/include/asm-arm/platforms/sunxi.h
> new file mode 100644
> index 0000000..4b7f48c
> --- /dev/null
> +++ b/xen/include/asm-arm/platforms/sunxi.h
>
I know the other existing platforms have such a header, but I think that
was a mistake/historical relic from early platforms having their fingers
outside of their own .c file.

So, please can you just add what you need to sunxi.c.

Thanks, Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel