Re: [Xen-devel] [PATCH RFC] x86/ACPI: allow CMOS RTC use even when ACPI says there is none

[Tim Deegan <tim@xxxxxxx>]

At 11:28 +0100 on 26 Jun (1403778496), Jan Beulich wrote:
> HP is setting the ACPI_FADT_NO_CMOS_RTC flag on newer systems,
> regardless of whether they're being booted from UEFI. Add a command
> line option to allow probing for a working RTC in that case.

I like this general direction.  I would add a printk in the case where
we are probing, since the probe will stall boot for >= 1 sec.

Maybe also worth checking that the times returned on the two passes
actually make sense (i.e. that the difference in RTC times matches the
difference in NOW() to within +/- 10ms).

Thirdly, since get_cmos_time() can be called more than once, I think
that just leaving cmos_rtc_probe == 0 could make us panic on the second
invocation.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel