Re: [Xen-devel] [PATCH v2 1/3] [GSOC14] refactored mempaging code from xenpaging to libxc.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-27 at 11:27 +0100, Ian Campbell wrote:
> On Mon, 2014-06-16 at 23:50 +0530, Dushyant Behl wrote:
> > This patch is part of the work done under the gsoc project -
> > Lazy Restore Using Memory Paging.
> 
> For future patches please can you omit this, it's not really relevant to
> the commit history. If you really want to include it please put it below
> the --- marker. Or just mention it in the 0/N mail.

Also please can you tag your $subject with the appropriate subsystem.
e.g.: "tools: refactor mempaging ...."

See git log for examples of how this normally looks.

> > +    /* Now that the ring is set, remove it from the guest's physmap */
> > +    if ( xc_domain_decrease_reservation_exact(xch, domain_id, 1, 0, 
> > &ring_pfn) )
> 
> ... the lack of a domain pause and/or clearing the ring content in this
> function does not represent an issue similar to
> http://xenbits.xen.org/xsa/advisory-99.html.

I found the answer to this in patch #3, but I had questions on that so I
haven't applied yet.

[...]
> Neither of those last two are a blocker for applying though.

But since it seems likely that a v3 is going to be required, please do
fix for next time.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel