Re: [Xen-devel] [PATCH v10 05/11] libxl: Change default for b_info->{cpu, node}map to "not allocated"

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2014-06-27 at 11:44 +0100, Ian Campbell wrote:
> On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> > by avoiding allocating them in libxl__domain_build_info_setdefault.
> > In fact, back in 7e449837 ("libxl: provide _init and _setdefault for
> > libxl_domain_build_info") and a5d30c23 ("libxl: allow for explicitly
> > specifying node-affinity"), it was decided that the default for these
> > fields was for them to be allocted and filled.
> 
> "allocated"
> 
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> > +     * updated accordingly; if it does not manage, inf->nodemap is just 
> > left
> 
> info-> ?
> 
Indeed.

And I'll fix these and resend, since it looks like I need to :-)

> > +     * alone. It is then the the subsequent call to
> > +     * libxl_domain_set_nodeaffinity() that enacts the actual placement.
> >       */
> >      if (libxl_defbool_val(info->numa_placement)) {
> > -        if (!libxl_bitmap_is_full(&info->cpumap)) {
> > +        if (info->cpumap.size) {
> 
> Not for now but a helper for this might be nice on day.
> 
Noted.

> >              LOG(ERROR, "Can run NUMA placement only if no vcpu "
> > -                       "affinity is specified");
> > +                       "affinity is specified explicitly");
> 
> OOI, this says "Can run", I think what it really means is "I will run"?
> No change needed just curious.
> 
"Can run" is a bad choice of words. The idea is that, if the user
specified any of those fields, NUMA node affinity will be based on that,
so we don't want automatic placement to take place. So, yes, something
like "NUMA placement won't run" or similar would have been more
appropriate.

Anyway, I've got an unrelated patch touching this code, which I'll
submit as soon as this one will be in. If you're fine, I'll leave it
alone in the repost of this series, and amend it there.

> I'll fix the two typos on commit, assuming nothing in the remainder of
> the series requires a resend.
> 
As said, I'm resending, so I'll also take care of the typos.

Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel