[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 10/11] libxl/xl: make it possible to specify soft-affinity in domain config file

On Fri, 2014-06-20 at 18:20 +0200, Dario Faggioli wrote:
> +        /*
> +         * If buf2 is not initialized above, gcc >= 4.9.0 complains with
> +         * a '[-Werror=maybe-uninitialized]'. That can't happen, though, 
> since
> +         * we use buf2 only if buf is NULL, and if we are here and buf is 
> +         * it means buf2 is non-NULL, and contains the j-eth element of the
> +         * list, as per the condition of the while().

You state that buf2 is non NULL only if buf is NULL (buf2 != NULL => buf
== NULL). But the logic here is based on the inverse (buf == NULL =>
buf2 != NULL).

I haven't read the code carefully to decide if you actually meant "we
use buf2 only iff buf is NULL".

A comment about a workaround such as this belongs next to the
workaround, i.e. next to the spurious looking = NULL. No need to then
back reference it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.