[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH ARM v5 17/20] mini-os: headers for ARM



On Fri, 2014-06-27 at 14:02 +0100, Thomas Leonard wrote:

> >> +#define BUG() while(1){}
> >
> > It looks odd to use onely while (1). Shouldn't you call do_exit as x86 does?
> 
> Note that patch #20 changes this to dump the registers and stack.
> 
> [ also, exiting on BUG is annoying because you may lose the console
> output if the VM dies before xl attaches to it. ]

That's what on_crash=preserve and xenconsoled's logging capabilities are
for. I expect SCHEDOP_crash is probably better than exiting though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.