Re: [Xen-devel] [PATCH v10 04/11] xl: enable getting and setting soft affinity

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2014-06-27 at 13:33 +0100, Ian Campbell wrote:
> On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> > Getting happens via `xl vcpu-list', which now looks like this:
> 
> With this I'm seeing:
>         
>         xl_cmdimpl.c: In function âvcpupin_parseâ:
>         xl_cmdimpl.c:661:5: error: passing argument 1 of â__strtok_r_1câ 
> discards âconstâ qualifier from pointer target type [-Werror]
>         In file included from /usr/include/string.h:637:0,
>                          from xl_cmdimpl.c:21:
>
Do you? You mean with patches 1-to-4 (this one) applied? That's weird,
as I just performed a clean build of that scenario to verify this, and
it ended without errors for me.

It's even more strange as the patch contains the hunk below, which is
specifically meant at avoiding what you report... :-O

--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -656,7 +656,7 @@ static int update_cpumap_range(const char *str,
libxl_bitmap *cpumap)
  * single cpus or as eintire NUMA nodes) and turns it into the
  * corresponding libxl_bitmap (in cpumap).
  */
-static int vcpupin_parse(char *cpu, libxl_bitmap *cpumap)
+static int vcpupin_parse(const char *cpu, libxl_bitmap *cpumap)
 {
     char *ptr, *saveptr = NULL;
     int rc = 0;

Anyway, to be sure, I just compile tested the full series, patch after
patch, and that also went well.

I'm not sure what's going on!

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel