Re: [Xen-devel] [PATCHv6 0/8] tools: rework VM Generation ID

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-18 at 17:12 +0100, David Vrabel wrote:
> This series reworks the VM Generation ID to a) conform to the
> published spec from Microsoft; b) simplify the save/restore code; and
> c) extend the libxl API to allow toolstacks to use this feature.
> 
> The VM Generation ID must be regenerated with a new random ID after
> certain VM operations. Since xl lacks infrastructure for tracking the
> life-cycle of snapshots and clones (etc), the safe option of always
> using a new generation ID is used.
> 
> You can download the spec from:
> 
>   http://www.microsoft.com/en-us/download/details.aspx?id=30707
> 
> Patch status ([A]cked, [M]odified, [N]ew):
> 
> M libxc: add xc_hvm_param_get/set() to get/set 64-bit
> A libxl: add libxl__random_bytes() which fills a buffer
> A hvmloader: add helper functions to get/set HVM params
> A hvm: add HVM_PARAM_VM_GENERATION_ID_ADDR
> A libxc,libxl,hvmloader: strip out outdated VM generation

I acked and applied up to here. thanks.

One hunk against tools/tests/xen-access/xen-access.c in the first patch
failed to apply and the new code in tools/libxc/xc_mem_event.c was
different enough that I didn't feel confident just fixing it. So I
dropped that hunk which was OK because the old functions remain. Perhaps
you or Aravindh (ccd) could followup with a fix?

> M libxl: allow a generation ID to be specified at domain

YHM about this one.

> M xl: generate a new random VM generation ID if requested

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> A docs: update docs for the ~/platform/generation-id key

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel