Re: [Xen-devel] [PATCH v6a 14/17] xen/arm: calculate vgic irq rank based on register size

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-26 at 13:58 +0100, Julien Grall wrote:

> > +/* HSR data abort size definition */
> > +enum dabt_size {
> > +    DABT_BYTE        = 0,
> > +    DABT_HALF_WORD   = 1,
> > +    DABT_WORD        = 2,
> > +    DABT_DOUBLE_WORD = 3,
> > +};
> > +
> 
> The enum looks like pointless here as you never use the defined type...

Using an enum just to get named values like this is completely fine
though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel