[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball



On 07/08/2014 10:50 AM, Ian Jackson wrote:
George Dunlap writes ("Re: [PATCH 2/2] make: Make "src-tarball" target actually make 
a source tarball"):
On 07/03/2014 09:29 AM, Ian Campbell wrote:
FWIW I think you could avoid much of this pushd/popd stuff with tar -C
and git --git-dir= (perhaps --work-dir, not sure for git archive).

   The --git-dir think seemed to work differently enough to hg's "-C"
option that I didn't really trust it.  If you think it's better I can
try to work it out.

Firstly, thanks for cleaning up this area, which sorely needs it.

Please don't.  I wouldn't really trust it either :-).

Instead of pushd/popd, you might consider ( ).

Well I've rewritten it with --git-dir already, and it looks a lot cleaner. I'll send that version and you can see what you think.

(May be a few days.)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.