Re: [Xen-devel] [PATCH] Fix builind error for old gcc

[Wei Liu <wei.liu2@xxxxxxxxxx>]

(There's typo in subject line)

CC'ing Ian

On Fri, Jul 11, 2014 at 11:32:33AM +0800, Wen Congyang wrote:
> commit de18e4c038306aeeca53e6e63e563036cafef162 introduces a building error:
> gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 
> -Wall -Wstrict-prototypes -Wdeclaration-after-statement 
> -Wno-unused-but-set-variable   -D__XEN_TOOLS__ -MMD -MF .xl.o.d 
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
> -Werror -Wno-format-zero-length -Wmissing-declarations 
> -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread 
> -I/home/wency/src/upstream/xen/tools/libxl/../../tools/libxc 
> -I/home/wency/src/upstream/xen/tools/libxl/../../tools/include  
> -I/home/wency/src/upstream/xen/tools/libxl/../../tools/libxl 
> -I/home/wency/src/upstream/xen/tools/libxl/../../tools/libxc 
> -I/home/wency/src/upstream/xen/tools/libxl/../../tools/include 
> -I/home/wency/src/upstream/xen/tools/libxl/../../tools/include -Wshadow 
> -include /home/wency/src/upstream/xen/tools/libxl/../../tools/config.h   -c 
> -o xl.o xl.c
> In file included from xl.c:31:
> libxl.h:582: error: redefinition of typedef âlibxl_ctxâ
> libxl.h:348: note: previous declaration of âlibxl_ctxâ was here
> 
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index e6e0301..5ae6532 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -579,8 +579,6 @@ typedef struct libxl__ctx libxl_ctx;
>   */
>  #define LIBXL_HAVE_CPUPOOL_NAME 1
>  
> -typedef struct libxl__ctx libxl_ctx;
> -

Sigh, this duplicated definition sneaked in again.

Thanks for fixing this.

Wei.

>  typedef uint8_t libxl_mac[6];
>  #define LIBXL_MAC_FMT "%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx"
>  #define LIBXL_MAC_FMTLEN ((2*6)+5) /* 6 hex bytes plus 5 colons */
> -- 
> 1.9.3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel