Re: [Xen-devel] [PATCH 2/3] xen: arm: when ALLOCATING p2m entries maddr is meaningless

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 07/14/2014 05:27 PM, Ian Campbell wrote:
> The maddr differs on each loop depending on the pages which happen to get
> allocated.
> 
> There is already an assertion that maddr == 0.

I think we hit the assert we don't use 1:1 mapping for DOM0.


> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

> ---
>  xen/arch/arm/p2m.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 917baa3..a10cbaf 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -501,7 +501,6 @@ static int apply_one_level(struct domain *d,
>                  p2m->stats.mappings[level]++;
>  
>                  *addr += level_size;
> -                *maddr += level_size;
>  
>                  return P2M_ONE_PROGRESS;
>              }
> 

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel