Re: [Xen-devel] [PATCH ARM v6 01/14] mini-os: x86_64: make thread stacks 16-byte aligned

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Thomas Leonard, le Wed 16 Jul 2014 12:07:41 +0100, a écrit :
> Otherwise, passing doubles to varargs functions causes a crash.
> 
> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
>  extras/mini-os/arch/x86/sched.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/extras/mini-os/arch/x86/sched.c b/extras/mini-os/arch/x86/sched.c
> index 8a05b58..e4a3dc2 100644
> --- a/extras/mini-os/arch/x86/sched.c
> +++ b/extras/mini-os/arch/x86/sched.c
> @@ -107,6 +107,9 @@ struct thread* arch_create_thread(char *name, void 
> (*function)(void *),
>      thread->sp = (unsigned long)thread->stack + STACK_SIZE;
>      /* Save pointer to the thread on the stack, used by current macro */
>      *((unsigned long *)thread->stack) = (unsigned long)thread;
> +
> +    /* Must ensure that (%rsp + 8) is 16-byte aligned at the start of 
> thread_starter. */
> +    thread->sp -= sizeof(unsigned long);
>      
>      stack_push(thread, (unsigned long) function);
>      stack_push(thread, (unsigned long) data);
> -- 
> 2.0.1
> 

-- 
Samuel
<m> argh, pi est plus grand que 2. Ca casse tout
 -+- #ens-mim -+-

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel