[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
- To: linux-pci@xxxxxxxxxxxxxxx
- From: Benoit Taine <benoit.taine@xxxxxxx>
- Date: Fri, 18 Jul 2014 17:26:47 +0200
- Cc: linux-mips@xxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, benoit.taine@xxxxxxx, ath5k-devel@xxxxxxxxxxxxxxxx, linux-acenic@xxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, ath10k@xxxxxxxxxxxxxxxxxxx, linux-hippi@xxxxxxxxxx, industrypack-devel@xxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, MPT-FusionLinux.pdl@xxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, ath9k-devel@xxxxxxxxxxxxxxxx, wil6210@xxxxxxxxxxxxxxxx, linux-pcmcia@xxxxxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, users@xxxxxxxxxxxxxxxxxxxxxxx, e1000-devel@xxxxxxxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 18 Jul 2014 15:34:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;
// </smpl>
I have 103 patches ready, and will only send a few for you to judge if
it is useful enough, and to prevent from spamming too much.
Thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
