Re: [Xen-devel] [PATCH v2 5/4] xen: arm: ensure that the boot code is <4K in size

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-07-21 at 11:39 +0100, Ian Campbell wrote:
> On Fri, 2014-07-18 at 18:06 +0100, Andrew Cooper wrote:
> > On 18/07/14 17:57, Ian Campbell wrote:
> > > This avoids having to deal with the 1:1 boot mapping crossing a
> > > section or page boundary.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > ---
> > >  xen/arch/arm/arm32/head.S |    3 +++
> > >  xen/arch/arm/arm64/head.S |    3 +++
> > >  xen/arch/arm/xen.lds.S    |    6 ++++++
> > >  3 files changed, 12 insertions(+)
> > >
> > > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> > > index caf7934..b4c3973 100644
> > > --- a/xen/arch/arm/arm32/head.S
> > > +++ b/xen/arch/arm/arm32/head.S
> > > @@ -458,6 +458,9 @@ fail:   PRINT("- Boot failed -\r\n")
> > >  1:      wfe
> > >          b     1b
> > >  
> > > +.globl _end_boot
> > > +_end_boot:
> > > +
> > 
> > GLOBAL() should be in scope (although git grep shows that some use of
> > .global has slipped back into the arm .S files)
> 
> Thanks, I only knew about ENTRY which didn't seem appropriate. I don't
> think this warrants a resend so I'll do it on commit unless someone
> objects to that.

I hadn't spotted Julien's comments on #2, so there will need to be a
respin anyway, I'll fix this for that.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel