Re: [Xen-devel] [PATCH] fix list_domain_details: check config data length=0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-23 at 11:09 +0100, Wei Liu wrote:
> On Wed, Jul 23, 2014 at 10:53:16AM +0100, Ian Campbell wrote:
> > On Wed, 2014-07-23 at 17:42 +0800, Chunyan Liu wrote:
> > > If domain is created through virsh, then in xl, one could see it
> > > with 'xl list', but with 'xl list --long domU', it reports:
> > > "Domain name must be specified."
> > > The reason is xl config data does not exist but it still tries
> > > to parse_config_data in current code.
> > > 
> > > Improve list_domain_details:
> > > If len of config data is 0, just pass, do not go forward to
> > > parse_config_data, otherwise, it will meet error like
> > > "Domain name not specified" and exit. This error is not expected,
> > > since if code enters list_domain_details, domain name validness
> > > is already checked and domain does exist.
> > > 
> > > Length of config data is 0 may means: config data does not exist due
> > > to some reason, like: domain is created by libvirt, or in destroying
> > > domain process config data is cleared but domain fails to clean up.
> > > No matter in which case, list_domain_details could just show empty
> > > info, but not error like "Domain name not specified".
> > > 
> > > Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>
> > 
> > I think this issue is resolved by Wei's "libxl: synchronise domain
> > configuration" series? That will save state in such a way that xl can
> > list libvirt domains etc.
> > 
> 
> If libvirt opt-in to use the new infrasturcture then yes, otherwise no.
> 
> So I think we need this patch until libvirt switches to make sure our
> new feature.

Isn't it all handled transparently inside libxl? At least from the PoV
of libvirt creating a domain and xl list showing it?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel