[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/2] xen: export do_yield as vcpu_yield
On 07/23/2014 02:04 PM, Stefano Stabellini wrote:
On Wed, 23 Jul 2014, George Dunlap wrote:
On 07/23/2014 01:05 PM, Stefano Stabellini wrote:
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
CC: george.dunlap@xxxxxxxxxxxxx
CC: JBeulich@xxxxxxxx
---
xen/common/schedule.c | 10 +++++-----
xen/include/xen/sched.h | 1 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/xen/common/schedule.c b/xen/common/schedule.c
index e9eb0bc..6631dc8 100644
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -795,9 +795,8 @@ static long do_poll(struct sched_poll *sched_poll)
}
/* Voluntarily yield the processor for this allocation. */
-static long do_yield(void)
+void vcpu_yield(struct vcpu *v)
What are you actually trying to do here? Why do you add a vcpu struct, when
all the callers (including the one you add in 2/2) just pass current?
I was just trying to be coherent with the other vcpu_* functions in
sched.h.
I see. Yeah, I think even apart from the rest of it, "yield" implies
"myself"; you can't really yield someone else. :-)
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
