Re: [Xen-devel] [PATCH v1 01/10] libxl: libxl-json format and internal functions to get / set it

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH v1 01/10] libxl: libxl-json format and internal 
functions to get / set it"):
> Introduce a new format in libxl userdata store called "libxl-json". This
> file format contains JSON version of libxl_domain_config, generated by
> libxl.
...
> + *  "libxl-json"  libxl_domain_config object in JSON format, generated
> + *                by libxl

Applications should probably be more strongly discouraged from
accessing this directly, at least by wording here in this comment.

> +int libxl__set_domain_configuration(libxl__gc *gc, uint32_t domid,
> +                                    libxl_domain_config *d_config)
> +{
> +    char *d_config_json;
> +    int rc;
> +
> +    d_config_json = libxl_domain_config_to_json(CTX, d_config);
> +    if (!d_config_json) {
> +        LOGE(ERROR, "failed to convert domain configuration to JSON for 
> domain %d",

If you add a newline before the first " this won't need to wrap.


Aside from that,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel