Re: [Xen-devel] [PATCH v9 05/10] xen/arm: physical irq follow virtual irq

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 28 Jul 2014, Julien Grall wrote:
> Hi stefano,
> 
> On 07/24/2014 06:33 PM, Stefano Stabellini wrote:
> > +void arch_move_irqs(struct vcpu *v)
> > +{
> > +    const cpumask_t *cpu_mask = cpumask_of(v->processor);
> > +    struct domain *d = v->domain;
> > +    struct pending_irq *p;
> > +    struct vcpu *v_target;
> > +    int i;
> > +
> > +    for ( i = 32; i < d->arch.vgic.nr_lines; i++ )
> 
> Sorry, I didn't spot this error until now.
> 
> For the VGIC nr_lines contains the number of *SPIs* rather on the GIC
> structure it's the number of IRQs... the name is very confusing. I have
> a patch to rename nr_lines into nr_spis, along with adding a macro
> vgic_number_lines.

I couldn't parse this sentence.
I guess you are saying that vgic.nr_lines doesn't represent the number
of spis?


> I plan to send it which my device passthrough patch series. As the patch
> may help you. It may be better if you carry the patch.

Please append it here so I can have a look.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel