Re: [Xen-devel] [PATCH v3 09/15] xen/arm: Add set access required domctl

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Mon, Sep 1, 2014 at 9:10 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hello Tamas,

On 01/09/14 10:22, Tamas K Lengyel wrote:

Signed-off-by: Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>
---
  xen/arch/arm/domctl.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)

diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 45974e7..7cf719c 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -31,6 +31,19 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
          return p2m_cache_flush(d, s, e);
      }

+    case XEN_DOMCTL_set_access_required:
+    {
+        struct p2m_domain* p2m;
+
+        if ( current->domain == d )
+            return -EPERM;
+
+        p2m = p2m_get_hostp2m(d);

p2m_get_hostp2m is only defined in the next patch (#9), therefore this patch won't compile.

Regards,

--
Julien Grall

Doh.. Thanks for spotting it.

I wish there was some automated testing infrastructure that would catch dumb mistakes like that. Do you guys have your own custom script setup that you do tests with or some continuous integration tests running on git branches? I have found it very useful on github to do automated compile + feature tests with Jenkins for pull requests.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel