Re: [Xen-devel] [PATCH v2 1/3] Add vmware_hw to xl.cfg

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.09.14 at 20:24, <dslutz@xxxxxxxxxxx> wrote:
> On 09/02/14 03:28, Jan Beulich wrote:
>>>>> On 01.09.14 at 17:33, <dslutz@xxxxxxxxxxx> wrote:
>>> So based on this, I picked the order:
>>>
>>> 0x40000000 is viridian, vmware or xen
>>> 0x40000100 is vmware or xen
>>> 0x40000200 is xen
>> Is there really a point in enabling both Viridian and VMware extensions
>> at the same time?
> 
> Not that I know of (and I do not want to say there there is no code
> out there that can work with both).  Instead of an error or warning
> I went with what xen is currently doing and that seabios was happy
> to find xen at 0x40000200.
> 
> If the consensus is to ignore, or report an error or warning I will go that
> way.  For now I am not planning on changing.

My personal take on this is that the hypervisor (or perhaps already
the tools) should reject enabling both at the same time.

>>> @@ -149,8 +152,11 @@ void pci_setup(void)
>>>               pci_writew(devfn, 0x20, 0x0000); /* No smb bus IO enable */
>>>               pci_writew(devfn, 0xd2, 0x0000); /* No smb bus IO enable */
>>>               pci_writew(devfn, 0x22, 0x0000);
>>> -            pci_writew(devfn, 0x3c, 0x0009); /* Hardcoded IRQ9 */
>>> -            pci_writew(devfn, 0x3d, 0x0001);
>>> +            if ( !vmware_hw )
>>> +            {
>>> +                pci_writew(devfn, 0x3c, 0x0009); /* Hardcoded IRQ9 */
>>> +                pci_writew(devfn, 0x3d, 0x0001);
>>> +            }
>> This needs an explanation (it is merely being mentioned in the
>> description).
> 
> Ok, how does this comment sound:
> 
> /*
>   * When looking more like VMware, let the guest pick the
>   * PCI_INTERRUPT_LINE (0x3c) and the PCI_INTERRUPT_PIN(3d)
>   * instead of them being hardcoded.  This allows for example
>   * lscpci in the guest to match for "PIIX4 ACPI PM" what
>   * one gets on VMware.
>   */

The first sentence is just stating verbally what the code does, i.e.
pretty pointless. The second sentence - at least to me - doesn't
explain anything (to a large part perhaps because having lspci
produce identical output with real VMware is rather secondary a
goal imo).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel