[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] numa.c: use spaces instead of tabs

On Wed, Sep 3, 2014 at 8:29 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 03.09.14 at 13:59, <ufimtseva@xxxxxxxxx> wrote:
>> Jan, you say that such style is not used.. But numa.c uses tabs as
>> :set list shows and its not Xen style either.
>> Coding style says - 4 spaces for one level of indent. numa.c uses tabs
>> and sometimes space between tabs.
>> I am looking at the rest of the files in xen/arch/x86/ and see that
>> they have all same tab= 4 spaces for indentation.
>> for example see xen/arch/x86/domain.c.
>> I used this for vim to re-tab the file: set noai ts=4 sw=8 expandtab
>> Linux has 8 spaces for tabs.. So I am lost here.
> In a few files, original Linux style got retained, and we're accepting
> that. See for example xen/arch/x86/cpu/. As a result, keeping the
> file here as is would be fine (as indicated before); the only alternative
> would be to fully switch it to Xen style.
> Jan


I understand that, but that style is mixed. Not linux, not Xen :)
And tabs also do not make it look like linux.
But I got your point I think. Or leave it as it is (with tabs), or
change it to Xen style.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.