Re: [Xen-devel] [PATCH] linux_gntshr_munmap: munmap takes a length, not a page count

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 03/09/14 15:01, Ian Campbell wrote:
> On Mon, 2014-09-01 at 13:16 +0100, David Scott wrote:
>> This fixes a bug where if a client shares more than 1 page, the
>> munmap call fails to clean up everything. A process which does
>> a lot of sharing and unsharing can run out of resources.
> 
> The doc comment on xc_gntshr_munmap does say count is in pages, so your
> change is correct but all of the in tree callers seem to pass a number
> of bytes not a number of pages. i.e. everything in tools/libvchan passes
> n*PAGE_SIZE.
> 
> So I don't think this change is complete without also updating those.

Would the corrent non-ABI/API-breaking fix be to just update the
documentation?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel