Re: [Xen-devel] [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Wed, Sep 3, 2014 at 2:51 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
 

Coverity-ID: 1234366

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp

     p2m = p2m_get_hostp2m(v->domain);
     mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
-                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
                               NULL);

     /* Check access permissions first, then handle faults */

Whops, that's my mistake. Sorry about that.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel