Re: [Xen-devel] [PATCH] numa.c: convert to xen coding style

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.09.14 at 06:23, <ufimtseva@xxxxxxxxx> wrote:
> Will be this a better version of converting to Xen coding style?

Yes - just that you should have build tested this: The patch added
an unused variable:

> @@ -346,64 +356,68 @@ EXPORT_SYMBOL(node_data);
>
>  static void dump_numa(unsigned char key)
>  {
> -       s_time_t now = NOW();
> -       int i;
> -       struct domain *d;
> -       struct page_info *page;
> -       unsigned int page_num_node[MAX_NUMNODES];
> -
>[...]
> +    s_time_t now = NOW();
> +    int i;
> +    struct domain *d;
> +    struct page_info *page;
> +    unsigned int page_num_node[MAX_NUMNODES];
> +    uint64_t mem;
> +

I fixed this and did a few minor other style adjustments before
committing right away.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel