Re: [Xen-devel] [PATCH RFC 1/7] xen/x86: Add mbd.h header file

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 3 Sep 2014, Daniel Kiper wrote:
> On Wed, Sep 03, 2014 at 03:11:18PM +0100, Ian Campbell wrote:
> > On Mon, 2014-08-11 at 17:16 +0100, Stefano Stabellini wrote:
> > > Also in the interest of code sharing across multiple arches, it seems to
> > > me that these struct should be common code.
> >
> > I don't intend to block the existing arm64 UEFI work for not using this
> > new infrastructure, so any code sharing common stuff would have to come
> > later.
> >
> > Whether it makes sense to preemptively make this new stuff common I'm
> > not sure. As it stands the mem_* and mmap(_size) fields aren't really
> > architecture agnostic.
> 
> I thought about sharing xbi_t instead of mbd_t (please look into patch 2 in
> this series). xbi_t could contain arch member (I am not sure about that yet;
> Currently my patches use idea similar to page_info struct - I prefer this
> solution) which would be used to store arch specific stuff. Fortunately as
> I can see only arch specific code touches arch specific members. So it looks
> that xbi_t with common members among archs should work on any architecture.

I can see how xbi_t might be a better candidate for sharing. It does
contain a couple of arch specific fields, such as e820map, that could be
moved to an arch specific field.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel