Re: [Xen-devel] [PATCH v4 06/16] xen/mem_event: Relax error condition on debug builds

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Fri, Sep 5, 2014 at 11:25 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 05.09.14 at 10:58, <tklengyel@xxxxxxxxxxxxx> wrote:
> --- a/xen/common/mem_event.c
> +++ b/xen/common/mem_event.c
> @@ -278,7 +278,12 @@ void mem_event_put_request(struct domain *d,
>      if ( current->domain != d )
>      {
>          req->flags |= MEM_EVENT_FLAG_FOREIGN;
> -        ASSERT( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) );
> +#ifndef NDEBUG
> +        if ( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) )
> +            gdprintk(XENLOG_G_WARNING,
> +                     "Dom%"PRIu32" VCPU %"PRIu32" was not paused.\n",
> +                     d->domain_id, req->vcpu_id);
> +#endif

And now please use the conventional d%dv%d, to make domain/vcpu
specific log entries greppable.

Jan

Ack.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel