Re: [Xen-devel] [PATCH v4 02/16] xen: Relocate p2m_mem_access_resume to mem_access common

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Fri, Sep 5, 2014 at 11:43 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 05.09.14 at 11:25, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> On Fri, Sep 5, 2014 at 11:16 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
>> >>> On 05.09.14 at 10:58, <tklengyel@xxxxxxxxxxxxx> wrote:
>> > --- a/xen/common/mem_access.c
>> > +++ b/xen/common/mem_access.c
>> > @@ -29,6 +29,30 @@
>> >  #include <xen/mem_event.h>
>> >  #include <xsm/xsm.h>
>> >
>> > +void mem_access_resume(struct domain *d)
>> > +{
>> > +    mem_event_response_t rsp;
>> > +
>> > +    /* Pull all responses off the ring */
>> > +    while( mem_event_get_response(d, &d->mem_event->access, &rsp) )
>>
>> Please take the opportunity to fix the coding style here.
>
> Surely, but what would be preferred coding style here? A separate int rc
> for the value returned by mem_event_get_response?

No, I really just mean formatting: There is a stop missing in the
comment (and there was another such comment further down
iirc), and a blank missing after "while".

Jan

I see, OK.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel