Re: [Xen-devel] [PATCH] xc_cpuid_x86.c: No need to mask NX twice

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.09.14 at 15:54, <alfred.z.song@xxxxxxxxx> wrote:
> Hi, Jan
> 
> Generally, I agree with you. But it seems that we may not simply remove the
> ones from the 2 vendor specific functions and keep the generic one, because
> the bit could be still cleared eventually when is_pae is true. And I find
> PSE36 will be cleared permanently no matter is_pae is true or not. Actually
> the work below has been totally overlapped:
> 
>         if ( !is_pae )
> {
> 
>             clear_bit(X86_FEATURE_NX,
> regs[3]);
> 
>             clear_bit(X86_FEATURE_PSE36,
> regs[3]);
> 
>         }
> 
> How can we just "passthrough to cpu vendor specific functions" like leaf
> 0x80000000? like this:
> 
> 
>     case 0x80000000:
>     case
> 0x80000001:
> 
>         /* Passthrough to cpu vendor specific functions
> */
> 
>         break;
> 
> 
> Correct me if I missed something.

I'm sorry, but I don't think I understand what you're trying to say
or you're asking.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel