Re: [Xen-devel] [patch] xen-scsifront: use GFP_ATOMIC under spin_lock

[Juergen Gross <jgross@xxxxxxxx>]

On 09/08/2014 01:15 PM, Dan Carpenter wrote:
> This function is only called with a spin_lock held and IRQs disabled.
> The allocation is not allowed to sleep and NOIO is not sufficient, it
> has to be ATOMIC.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

Thanks,

Juergen

> diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
> index 0aceb70..7e88659 100644
> --- a/drivers/scsi/xen-scsifront.c
> +++ b/drivers/scsi/xen-scsifront.c
> @@ -359,7 +359,7 @@ static int map_data_for_request(struct vscsifrnt_info *info,
>                 }
>                 seg_grants = vscsiif_grants_sg(data_grants);
>                 shadow->sg = kcalloc(data_grants,
> -                       sizeof(struct scsiif_request_segment), GFP_NOIO);
> +                       sizeof(struct scsiif_request_segment), GFP_ATOMIC);
>                 if (!shadow->sg)
>                         return -ENOMEM;
>         }
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel