[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk

Hi Ian,

I forgot one point on my previous mail.

On 04/09/14 09:14, Ian Campbell wrote:
-    if ( first_table_offset(addr) >= LPAE_ENTRIES )
-        return;
+    mappings[root_level] = root;
+    for ( level = root_level; ; level++ )
+    {

I would add the check "level < 3" or an ASSERT in the beginning of the loop. So we could catch a possible overflow on offsets later if someone decide to modify it.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.