Re: [Xen-devel] [PATCH v10 06/20] vmx: Merge MSR management routines

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.09.14 at 19:28, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 09/08/2014 12:07 PM, Jan Beulich wrote:
>>>>> On 04.09.14 at 05:41, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> vmx_add_host_load_msr() and vmx_add_guest_msr() share fair amount of code.
>>> Merge
>>> them to simplify code maintenance.
>>>
>>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>>> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>> Considering the re-work, is this really valid?
> 
> Probably not (although the difference between this and earlier version 
> is removal of one of the two routines).
> 
> This also brings up another question --- I have kept Dietmar's Tested-by 
> tags for a while now and I believe he tested this quite a few revisions 
> back. I am not sure whether the tags are valid any longer. I would like 
> to keep them since it was very helpful work on his part but I don't know 
> what the policy is.

I personally think Tested-by ought to become invalid even with
minor code changes, as any non-comment change may introduce
some issue.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel