[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: remove DEFINE_XENBUS_DRIVER() macro

>>> On 08.09.14 at 18:46, <david.vrabel@xxxxxxxxxx> wrote:
> The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse
> errors.
> Replace the uses with standard structure definitions instead.  This is
> similar to pci and usb device registration.
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

I really regret you doing this, re-adding redundancy the elimination
of which the macro got added for (the diffstat would look even less
favorable if your patch didn't eliminate a couple of bogus comments
and blank lines). I'm certainly not in the position to nack this patch,
but if I was I would.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.