[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 07/15] libxl: disallow attaching the same device more than once

On Thu, 2014-09-04 at 23:43 +0100, Wei Liu wrote:
> Originally the code allowed users to attach the same device more than
> once. It just stupidly overwrites xenstore entries. This is bogus as
> frontend will be very confused.
> Introduce a helper function to check if the device to be written to
> xenstore already exists. A new error code is also introduced.
> The check and add are within one xs transaction.
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

But, it would be nice to send a followup which reduced the amount of
repetition on those transaction loops, apart from the disk one they are
all basically identical AFAICT.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.