[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] xen/tools: script for automatically adjusting the coding style to xen style



On 09/09/14 15:50, Ian Campbell wrote:
> On Tue, 2014-09-09 at 05:32 +0300, Mihai DonÈu wrote:
>> This is a clang-format wrapper script that can be used to do the bulk of the
>> coding style work on a foreign source file. It is not yet complete, but it's
>> sufficient for 98% of the cases.
> I think a lot of people would like to have something along these lines
> available. Don also proposed something recently, see [0]. Not sure what
> the hypervisor maintainers opinion is though, I've CCd a few for input.
>
> I've no prior experience with either clang-format or astyle so I don't
> know which is better, but I do like that clang-format doesn't need a
> second pass in emacs (despite being an emacs user).
>
> Ian.
>
> [0] http://lists.xen.org/archives/html/xen-devel/2014-09/msg00918.html

I have no experience with either, but +1 for the principle.  It would
vastly ease certain reviews with a single reference to how to correctly
format for Xen style.

The problem with Xen itself is working out which files have Linux style,
which have Xen style and which are currently a mix of the two, and which
are neither.

The problem could possibly be solved by a grepable tag in the emacs
style block?

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.