[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] x86: add support for computing the instruction length



>>> On 09.09.14 at 18:01, <mdontu@xxxxxxxxxxxxxxx> wrote:
> I've opted to send a new mail so I can remove Masami from CC, as he's
> probably not interested in the rest of the conversation.
> 
> Right now we have two patches which work around x86/emulator
> limitations:
> 
>  * one computes the instruction length;
>  * the other uses single stepping to jump over unsupported instructions;
> 
> Adding support for the complete x86(_64) instruction set to the
> existent emulator in Xen would make those two unneeded and while I
> would like to try my hand at it, I'm not sure the effort would be pay
> off. Not to mention that I would very much like to _somehow_ catch the
> 4.5 deadline. I wonder if it's possible to do this in iterations: take
> this (or a decent derivation of it) in, while RÄzvan and I work on doing
> a better work for 4.6. Am I pushing it? :-)

Personally I don't think this makes sense to push for 4.5, but in the
end it'll be Konrad's call. We already have enough other half-way
reviewed patch series that need finalizing, so I don't think this series
(which was posted just once many weeks ago) is a candidate.
Furthermore I'm rather unconvinced of this being code useful to
other than just your product. And finally, we had (with other
submitters) some bad experience in the past taking what they
promised they would clean up later.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.