Re: [Xen-devel] [PATCH v3 1/3] xc_cpuid_x86.c: Simplify masking conditions and remove redundant work

[z <alfred.z.song@xxxxxxxxx>]

On Wed, Sep 10, 2014 at 5:59 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 10.09.14 at 04:29, <alfred.z.song@xxxxxxxxx> wrote:
> * Since there would not be 32-bit hypervisor, we do not need
>Â Âhypervisor_is_64bit() again.
>
> * Remove xen_64bit from xc_cpuid_pv_policy().
>
> * Because is_64bit only depends on is_pae, only use is_pae for both
>Â Âvendor specific functions.
>
> * Move conditions for LM/NX masking into architectural logic
>
> Signed-off-by: Zhuo Song <songzhuo.sz@xxxxxxxxxxxxxxx>

You were asked to do everything in one patch on v2, and now it
became 3 patches? Please avoid the intermediate bogus state
and drop the two offending is_pae uses right away.

Jan

Right, that's what I am preparing to do.

I will resend it later. :)

Thanks.

Zhuo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel