[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv2] xen: remove DEFINE_XENBUS_DRIVER() macro

On 09/10/2014 06:25 PM, David Vrabel wrote:
On 10/09/14 17:00, Konrad Rzeszutek Wilk wrote:
On Wed, Sep 10, 2014 at 01:07:49PM +0100, David Vrabel wrote:
The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse

.. but it is also useful for downstream distros to bolt on Xen patches.

Is this urgent? Could it wait until Novell/SuSE has switched over
to using pvops and then this can go in?

If the macro didn't cause sparse errors, I could be persuaded to wait.

Couldn't you modify the current macro users to avoid the sparse errors?
E.g. by explicitly specifying the second argument as "NULL" when the
default is desired?

Removing the "+ 0" from evaluation of "drvname" in the macro definition
would enforce specifying "drvname".


I do not think we should avoid fixing bugs or improving the readability
or maintainability of the code to help out someone still using
non-upstream Xen support.

In general, the cost of maintaining non-upstream forks should not be
paid for by upstream users/developers.


Xen-devel mailing list

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.